[PATCH] D96638: [Driver][Windows] Support per-target runtimes dir layout for profile instr generate

Markus Böck via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 23 12:07:20 PST 2021


zero9178 updated this revision to Diff 325868.
zero9178 added a comment.
Herald added a subscriber: mstorsjo.

Refactored getCompilerRTBasename. It now simply refers to getCompilerRT, which gathers a full path to the specified runtime library. getCompilerRTBasename then simply returns only the filename component. The previous contents of getCompilerRTBasename have been refactored into a static function used by getCompilerRT. Only users of either of the two functions has been in clang-cl specific code and besides getCompilerRT, the AddArch parameter has never been explicitly specified. As it is now autodetected I think it makes sense to remove the parameter off of getCompilerRTBasename altogether as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96638/new/

https://reviews.llvm.org/D96638

Files:
  clang/include/clang/Driver/ToolChain.h
  clang/lib/Driver/ToolChain.cpp
  clang/lib/Driver/ToolChains/BareMetal.cpp
  clang/lib/Driver/ToolChains/BareMetal.h
  clang/test/Driver/cl-options.c
  clang/test/Driver/fsanitize.c
  clang/test/Driver/instrprof-ld.c
  clang/test/Driver/sanitizer-ld.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D96638.325868.patch
Type: text/x-patch
Size: 12133 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210223/9363e071/attachment-0001.bin>


More information about the cfe-commits mailing list