[PATCH] D96638: [Driver][Windows] Support per-target runtimes dir layout for profile instr generate

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 23 09:50:38 PST 2021


rnk added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:797
       CmdArgs.push_back(Args.MakeArgString(
-          "--dependent-lib=" + TC.getCompilerRTBasename(Args, "profile")));
+          "--dependent-lib=" + llvm::sys::path::filename(ClangRtProfilePath)));
     }
----------------
Is it possible to fix the problem in `getCompilerRTBasename` instead? I see 6-ish instances of this code pattern that need the same fix. It will require a small bit of refactoring to `getCompilerRT`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96638/new/

https://reviews.llvm.org/D96638



More information about the cfe-commits mailing list