[PATCH] D93223: [analyzer] Create MacroExpansionContext member in AnalysisConsumer

Wed Feb 10 02:53:58 PST 2021

steakhal added a comment.

In D93223#2553053 <https://reviews.llvm.org/D93223#2553053>, @Szelethus wrote:

> My no1. thought is that I wish the new functionality you're implementing was in the interface of the `Preprocessor`. I found, and still find it so hard to believe that you couldn't just retrieve this information

It is hard to believe, but it is the case.

> your projects seems to plug this gaping hole in the design.

I honestly think that it is the supposed way of doing this. The chained preprocessor callbacks and the token watcher fit perfectly into this picture.

> I respect that this is an opt-in functionality for now though, and I guess we could make this a default feature with relative ease.

We should carefully evaluate the impact and stability of this before making it happen.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93223/new/

https://reviews.llvm.org/D93223