[PATCH] D93223: [analyzer] Create MacroExpansionContext member in AnalysisConsumer

Kristóf Umann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 9 19:14:09 PST 2021


Szelethus accepted this revision.
Szelethus added a comment.
Herald added a subscriber: nullptr.cpp.

My no1. thought is that I wish the new functionality you're implementing was in the interface of the `Preprocessor`. I found, and still find it so hard to believe that you couldn't just retrieve this information -- your projects seems to plug this gaping hole in the design. I respect that this is an opt-in functionality for now though, and I guess we could make this a default feature with relative ease.

The actual patch is straightforward, LGTM!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93223/new/

https://reviews.llvm.org/D93223



More information about the cfe-commits mailing list