[PATCH] D95706: [clangd] Expose more dependent-name detail via semanticTokens

[Nathan Ridge via Phabricator via cfe-commits]

nridge accepted this revision.
nridge added a comment.
This revision is now accepted and ready to land.

Looks great, thanks again for doing this!



================
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:239
+  auto Result = Priority1 > Priority2 ? Tokens[0] : Tokens[1];
+  Result.Modifiers = Tokens[0].Modifiers | Tokens[1].Modifiers;
+  return Result;
----------------
I like that this ends up with a concrete kind + dependent modifier, to give a hint that the concrete kind was determined heuristically :)

Maybe we could adjust the comment at the top of the function to call this behaviour out.


================
Comment at: clang-tools-extra/clangd/SemanticHighlighting.h:78
   Abstract,
+  DependentName,
 
----------------
Just `Dependent` might be enough


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95706/new/

https://reviews.llvm.org/D95706