[PATCH] D95928: [OpenMP] Delay more diagnostics of potentially non-emitted code

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 2 22:57:55 PST 2021


jdoerfert created this revision.
jdoerfert added reviewers: JonChesterfield, grokos, ABataev, Fznamznon, tra, yaxunl.
Herald added a reviewer: bollu.
Herald added a subscriber: guansong.
jdoerfert requested review of this revision.
Herald added a subscriber: sstefan1.
Herald added a project: clang.

Even code in target and declare target regions might not be emitted.
With this patch we delay more diagnostics and use laziness and linkage
to determine if a function is emitted (for the device). Note that we
still eagerly emit diagnostics for target regions, unfortunately, see
the TODO for the reason.

This hopefully fixes PR48933.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D95928

Files:
  clang/lib/Sema/SemaDecl.cpp
  clang/lib/Sema/SemaOpenMP.cpp
  clang/test/OpenMP/nvptx_allocate_messages.cpp
  clang/test/OpenMP/nvptx_target_exceptions_messages.cpp
  clang/test/OpenMP/nvptx_unsupported_type_messages.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D95928.321013.patch
Type: text/x-patch
Size: 12858 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210203/80628963/attachment.bin>


More information about the cfe-commits mailing list