[PATCH] D95031: [clangd] Log warning when using legacy (theia) semantic highlighting.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 27 16:30:08 PST 2021


This revision was automatically updated to reflect the committed changes.
Closed by commit rG29472bb76915: [clangd] Log warning when using legacy (theia) semantic highlighting. (authored by sammccall).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95031/new/

https://reviews.llvm.org/D95031

Files:
  clang-tools-extra/clangd/ClangdLSPServer.cpp


Index: clang-tools-extra/clangd/ClangdLSPServer.cpp
===================================================================
--- clang-tools-extra/clangd/ClangdLSPServer.cpp
+++ clang-tools-extra/clangd/ClangdLSPServer.cpp
@@ -510,6 +510,11 @@
         "semanticTokens request, choosing the latter (no notifications).");
     Opts.TheiaSemanticHighlighting = false;
   }
+  if (Opts.TheiaSemanticHighlighting) {
+    log("Using legacy semanticHighlights notification, which will be removed "
+        "in clangd 13. Clients should use the standard semanticTokens "
+        "request instead.");
+  }
 
   if (Params.rootUri && *Params.rootUri)
     Opts.WorkspaceRoot = std::string(Params.rootUri->file());


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D95031.319713.patch
Type: text/x-patch
Size: 702 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210128/a898e7f9/attachment.bin>


More information about the cfe-commits mailing list