[PATCH] D95031: [clangd] Log warning when using legacy (theia) semantic highlighting.

Wed Jan 27 09:22:15 PST 2021

sammccall added a comment.

In D95031#2509896 <https://reviews.llvm.org/D95031#2509896>, @nridge wrote:

> Thanks for the heads up! It would be nice to get D77702 <https://reviews.llvm.org/D77702> landed before the removal of `TheiaSemanticHighlighting`. I'll try to find some time to rebase it.

Good point!
I've revived D77811 <https://reviews.llvm.org/D77811>, as I'd prefer not to start adding modifiers before can make them independent of kinds. (Moving features to different infrastructure tends to involve some backward-compatibility/testing toil...)

>From there I think it should be easy to get the rest of this merged:

- scope modifiers make a lot of sense and should be straightforward to add
- dependent type vs name: maybe we should consider making dependent a modifier instead? but otherwise LG
- the "member" issue I think has been resolved for the most part, by clarifying the spec

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95031/new/

https://reviews.llvm.org/D95031