[PATCH] D95442: [OpenCL] Add diagnostics for references to functions

[Marco Antognini via Phabricator via cfe-commits]

mantognini added a comment.

Looks sensible to me.



================
Comment at: clang/test/SemaOpenCLCXX/members.cl:17
-
-template <class T> struct remove_reference { typedef T type; };
-template <class T> struct remove_reference<T &> { typedef T type; };
----------------
I wonder, do we lose coverage by removing these templates?

In other words, is the same code for error detection used for templates and non-template?


================
Comment at: clang/test/SemaOpenCLCXX/references.cl:25
+#endif // FPTREXT
+typedef void (&ref2fct_t)();
+#ifndef FPTREXT
----------------
This re-uses the same name as above. Could that be an issue?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95442/new/

https://reviews.llvm.org/D95442