[PATCH] D95442: [OpenCL] Add diagnostics for references to functions

Anastasia Stulova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 26 11:44:27 PST 2021


Anastasia added inline comments.


================
Comment at: clang/test/SemaOpenCLCXX/references.cl:29
+void foo();
+void test(void (&par)()) {
+  void (&loc)();
----------------
Anastasia wrote:
> oops, I thought this was covered in my patch. I will see if there is a quick fix and if not I will create another PR.
Ok, I have addressed that. I realized that my original patch was not doing what I said in the description as it was still allowing the references to functions in type aliases or template arguments. While I think such functionality might be useful we should first start from the language definition side of it. For now let's just go with the conservative approach and disallow this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95442/new/

https://reviews.llvm.org/D95442



More information about the cfe-commits mailing list