[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 21 06:33:28 PST 2021


martong added a comment.

In D69726#2471657 <https://reviews.llvm.org/D69726#2471657>, @vabridgers wrote:

> I was referred to this patch from https://reviews.llvm.org/D86743. I pulled this patch under review, brought it up to date and pushed to github at https://github.com/vabridgers/llvm-project-dev.git, branch: vla-fam-fixes. Everything seems ok on this branch (LITs pass,  reproducers from https://bugs.llvm.org/show_bug.cgi?id=47272 and https://bugs.llvm.org/show_bug.cgi?id=28450 no longer crash). I can continue and push a change to Phabricator for review, or @charusso and/or @balazske could finish this? I didn't want to just push an update without asking first :/  Cheers!

Hi Vince and Artem,

I agree that this is an important patch. Unfortunately it got stuck. I see two possible solutions:

1. Vince commandeers this patch. I am not sure about the policy of commandeering a patch and that might be too intrusive.
2. Vince opens a new patch (a copy of this) and gives credit to @Charusso when he commits. I prefer this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69726/new/

https://reviews.llvm.org/D69726



More information about the cfe-commits mailing list