[PATCH] D94606: [clangd] Move DirBasedCDB broadcasting onto its own thread.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 13 08:13:56 PST 2021


sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: usaxena95, jfb, arphaman.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang.

This is on the critical path (it blocks getting the compile command for
the first file).

It's not trivially fast: it involves processing all filenames in the CDB
and doing some IO to look for shadowing CDBs.

And we may make this slower soon - making CDB configurable implies evaluating
the config for each listed to see which ones really are owned by the
broadcasted CDB.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D94606

Files:
  clang-tools-extra/clangd/GlobalCompilationDatabase.cpp
  clang-tools-extra/clangd/GlobalCompilationDatabase.h
  clang-tools-extra/clangd/unittests/GlobalCompilationDatabaseTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94606.316405.patch
Type: text/x-patch
Size: 9239 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210113/b49a2739/attachment-0001.bin>


More information about the cfe-commits mailing list