[clang-tools-extra] 95c7b6c - [clangd] zap a few warnings

Richard Smith via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 18 15:30:13 PST 2020


Thanks!

On Fri, 18 Dec 2020 at 07:34, Sam McCall via cfe-commits <
cfe-commits at lists.llvm.org> wrote:

>
> Author: Sam McCall
> Date: 2020-12-18T16:34:34+01:00
> New Revision: 95c7b6cadbc9a3d4376ef44edbeb3c8bb5b8d7fc
>
> URL:
> https://github.com/llvm/llvm-project/commit/95c7b6cadbc9a3d4376ef44edbeb3c8bb5b8d7fc
> DIFF:
> https://github.com/llvm/llvm-project/commit/95c7b6cadbc9a3d4376ef44edbeb3c8bb5b8d7fc.diff
>
> LOG: [clangd] zap a few warnings
>
> Added:
>
>
> Modified:
>     clang-tools-extra/clangd/DumpAST.cpp
>     clang-tools-extra/clangd/FindTarget.cpp
>     clang-tools-extra/clangd/index/remote/Client.cpp
>
> Removed:
>
>
>
>
> ################################################################################
> diff  --git a/clang-tools-extra/clangd/DumpAST.cpp
> b/clang-tools-extra/clangd/DumpAST.cpp
> index 12698b42ef3e..8f1b3f3a1aae 100644
> --- a/clang-tools-extra/clangd/DumpAST.cpp
> +++ b/clang-tools-extra/clangd/DumpAST.cpp
> @@ -143,6 +143,7 @@ class DumpVisitor : public
> RecursiveASTVisitor<DumpVisitor> {
>        TEMPLATE_ARGUMENT_KIND(Declaration);
>        TEMPLATE_ARGUMENT_KIND(Template);
>        TEMPLATE_ARGUMENT_KIND(TemplateExpansion);
> +      TEMPLATE_ARGUMENT_KIND(UncommonValue);
>  #undef TEMPLATE_ARGUMENT_KIND
>      }
>      llvm_unreachable("Unhandled ArgKind enum");
>
> diff  --git a/clang-tools-extra/clangd/FindTarget.cpp
> b/clang-tools-extra/clangd/FindTarget.cpp
> index 3afd65522680..c5c7d71be661 100644
> --- a/clang-tools-extra/clangd/FindTarget.cpp
> +++ b/clang-tools-extra/clangd/FindTarget.cpp
> @@ -1069,6 +1069,7 @@ class ExplicitReferenceCollector
>      case TemplateArgument::Pack:
>      case TemplateArgument::Type:
>      case TemplateArgument::Expression:
> +    case TemplateArgument::UncommonValue:
>        break; // Handled by VisitType and VisitExpression.
>      };
>      return RecursiveASTVisitor::TraverseTemplateArgumentLoc(A);
>
> diff  --git a/clang-tools-extra/clangd/index/remote/Client.cpp
> b/clang-tools-extra/clangd/index/remote/Client.cpp
> index b09dbf915e46..a153a8812baf 100644
> --- a/clang-tools-extra/clangd/index/remote/Client.cpp
> +++ b/clang-tools-extra/clangd/index/remote/Client.cpp
> @@ -152,7 +152,8 @@ class IndexClient : public clangd::SymbolIndex {
>                });
>    }
>
> -  llvm::unique_function<bool(llvm::StringRef) const> indexedFiles() const
> {
> +  llvm::unique_function<bool(llvm::StringRef) const>
> +  indexedFiles() const override {
>      // FIXME: For now we always return "false" regardless of whether the
> file
>      //        was indexed or not. A possible implementation could be
> based on
>      //        the idea that we do not want to send a request at every
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201218/a66e5d2c/attachment-0001.html>


More information about the cfe-commits mailing list