<div dir="ltr"><div dir="ltr">Thanks!</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, 18 Dec 2020 at 07:34, Sam McCall via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Sam McCall<br>
Date: 2020-12-18T16:34:34+01:00<br>
New Revision: 95c7b6cadbc9a3d4376ef44edbeb3c8bb5b8d7fc<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/95c7b6cadbc9a3d4376ef44edbeb3c8bb5b8d7fc" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/95c7b6cadbc9a3d4376ef44edbeb3c8bb5b8d7fc</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/95c7b6cadbc9a3d4376ef44edbeb3c8bb5b8d7fc.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/95c7b6cadbc9a3d4376ef44edbeb3c8bb5b8d7fc.diff</a><br>
<br>
LOG: [clangd] zap a few warnings<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    clang-tools-extra/clangd/DumpAST.cpp<br>
    clang-tools-extra/clangd/FindTarget.cpp<br>
    clang-tools-extra/clangd/index/remote/Client.cpp<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/clang-tools-extra/clangd/DumpAST.cpp b/clang-tools-extra/clangd/DumpAST.cpp<br>
index 12698b42ef3e..8f1b3f3a1aae 100644<br>
--- a/clang-tools-extra/clangd/DumpAST.cpp<br>
+++ b/clang-tools-extra/clangd/DumpAST.cpp<br>
@@ -143,6 +143,7 @@ class DumpVisitor : public RecursiveASTVisitor<DumpVisitor> {<br>
       TEMPLATE_ARGUMENT_KIND(Declaration);<br>
       TEMPLATE_ARGUMENT_KIND(Template);<br>
       TEMPLATE_ARGUMENT_KIND(TemplateExpansion);<br>
+      TEMPLATE_ARGUMENT_KIND(UncommonValue);<br>
 #undef TEMPLATE_ARGUMENT_KIND<br>
     }<br>
     llvm_unreachable("Unhandled ArgKind enum");<br>
<br>
diff  --git a/clang-tools-extra/clangd/FindTarget.cpp b/clang-tools-extra/clangd/FindTarget.cpp<br>
index 3afd65522680..c5c7d71be661 100644<br>
--- a/clang-tools-extra/clangd/FindTarget.cpp<br>
+++ b/clang-tools-extra/clangd/FindTarget.cpp<br>
@@ -1069,6 +1069,7 @@ class ExplicitReferenceCollector<br>
     case TemplateArgument::Pack:<br>
     case TemplateArgument::Type:<br>
     case TemplateArgument::Expression:<br>
+    case TemplateArgument::UncommonValue:<br>
       break; // Handled by VisitType and VisitExpression.<br>
     };<br>
     return RecursiveASTVisitor::TraverseTemplateArgumentLoc(A);<br>
<br>
diff  --git a/clang-tools-extra/clangd/index/remote/Client.cpp b/clang-tools-extra/clangd/index/remote/Client.cpp<br>
index b09dbf915e46..a153a8812baf 100644<br>
--- a/clang-tools-extra/clangd/index/remote/Client.cpp<br>
+++ b/clang-tools-extra/clangd/index/remote/Client.cpp<br>
@@ -152,7 +152,8 @@ class IndexClient : public clangd::SymbolIndex {<br>
               });<br>
   }<br>
<br>
-  llvm::unique_function<bool(llvm::StringRef) const> indexedFiles() const {<br>
+  llvm::unique_function<bool(llvm::StringRef) const><br>
+  indexedFiles() const override {<br>
     // FIXME: For now we always return "false" regardless of whether the file<br>
     //        was indexed or not. A possible implementation could be based on<br>
     //        the idea that we do not want to send a request at every<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><br>
</blockquote></div></div>