[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

Mircea Trofin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 14 07:33:55 PST 2020


mtrofin marked an inline comment as done.
mtrofin added a comment.

In D93078#2451747 <https://reviews.llvm.org/D93078#2451747>, @pengfei wrote:

> What's the difference with the existing code? It looks to me that you just brought the warning out of loop, right?

Oh true! we can just do the check in build_function_body_dictionary_for_triple at the end.

I'll leave the additional tests, though, more tests never hurt.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93078/new/

https://reviews.llvm.org/D93078



More information about the cfe-commits mailing list