[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

[Pengfei Wang via Phabricator via cfe-commits]

pengfei added a comment.

What's the difference with the existing code? It looks to me that you just brought the warning out of loop, right?



================
Comment at: llvm/utils/update_analyze_test_checks.py:128
           raw_tool_output, prefixes, func_dict, func_order, args.verbose, False, False)
-
+    
+    common.warn_on_failed_prefixes(func_dict)
----------------
redundant space.


================
Comment at: llvm/utils/update_analyze_test_checks.py:129
+    
+    common.warn_on_failed_prefixes(func_dict)
     is_in_function = False
----------------
Can we move these warn to common.py?


================
Comment at: llvm/utils/update_cc_test_checks.py:269
         line2spell_and_mangled_list[k].append(v)
-
+    
+    common.warn_on_failed_prefixes(func_dict)
----------------
redundant space.


================
Comment at: llvm/utils/update_test_checks.py:120
               ti.args.function_signature, ti.args.check_attributes)
-
+    
+    common.warn_on_failed_prefixes(func_dict)
----------------
redundant space.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93078/new/

https://reviews.llvm.org/D93078