[PATCH] D93113: [clangd] Use enumMember instead of enumConstant

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 11 06:25:16 PST 2020


njames93 added inline comments.


================
Comment at: clang-tools-extra/clangd/SemanticHighlighting.h:51
   Enum,
-  EnumConstant,
+  EnumMember,
   Typedef,
----------------
sammccall wrote:
> `HighlightingKind` is an internal enum that doesn't match LSP naming, so no need for changes there.
It doesn't strictly need it, But I do like the consistency of it being EnumMember throughout. I'll revert though as its not essential.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93113/new/

https://reviews.llvm.org/D93113



More information about the cfe-commits mailing list