[PATCH] D93113: [clangd] Use enumMember instead of enumConstant

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 11 06:05:46 PST 2020


sammccall added a comment.

Thanks! Most of the changes in this patch are to the internal infrastructure, which predates LSP semanticTokens and doesn't need to have names that match (in many cases the names don't closely match C++ convention).
I think only the `toSemanticTokenType` change is needed.



================
Comment at: clang-tools-extra/clangd/SemanticHighlighting.h:51
   Enum,
-  EnumConstant,
+  EnumMember,
   Typedef,
----------------
`HighlightingKind` is an internal enum that doesn't match LSP naming, so no need for changes there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93113/new/

https://reviews.llvm.org/D93113



More information about the cfe-commits mailing list