[PATCH] D92531: Basic: Support named pipes natively in SourceManager

[Duncan P. N. Exon Smith via Phabricator via cfe-commits]

dexonsmith marked an inline comment as done.
dexonsmith added inline comments.


================
Comment at: clang/lib/Basic/SourceManager.cpp:567
+  if (IR.ContentsEntry->isNamedPipe())
+    (void)IR.getBufferOrNone(Diag, getFileManager(), SourceLocation());
+
----------------
jansvoboda11 wrote:
> What's the reason behind duplicating the logic here instead of calling `createFileID` with `const FileEntry *SourceFile`?
Yeah, I noticed the duplication too; and then I removed the other one with https://reviews.llvm.org/D92984, but forgot to rebase this on top of it. Done now!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92531/new/

https://reviews.llvm.org/D92531