[PATCH] D92531: Basic: Support named pipes natively in SourceManager

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 10 13:26:14 PST 2020


dexonsmith updated this revision to Diff 311004.
dexonsmith retitled this revision from "Reapply "Frontend: Sink named pipe logic from CompilerInstance down to FileManager"" to "Basic: Support named pipes natively in SourceManager".
dexonsmith edited the summary of this revision.
dexonsmith added a comment.

Updates:

- Rebased on top of https://reviews.llvm.org/D92984, which drops the `const FileEntry*` version of `createFileID`.
- Add a test for `#include`-ing from a named pipe, which now works because the named pipe support is native to SourceManager instead of special logic in `CompilerInstance`.
- Updated the commit message / summary / title to better reflect the commit content. The new changes are bigger than the original, and I realized that describing it as a revert-of-a-revert+changes was inaccurate.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92531/new/

https://reviews.llvm.org/D92531

Files:
  clang/lib/Basic/FileManager.cpp
  clang/lib/Basic/SourceManager.cpp
  clang/lib/Frontend/CompilerInstance.cpp
  clang/test/Misc/dev-fd-fs.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92531.311004.patch
Type: text/x-patch
Size: 5719 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201210/d5d447a4/attachment.bin>


More information about the cfe-commits mailing list