[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 10 05:47:36 PST 2020


martong added a comment.

I wouldn't worry much about the `ASTMerge` tests, those are mostly legacy and not actively used nowadays. (At one point we were thinking even to remove them because we could got rid of the `ASTMergeAction` which is exclusively used for testing.)
The main test infrastructure for the ASTImporter is in the `unittests`. Those tests are exercised even with `-fdelayed-template-parsing` and with `-fms-compatibility`. So I am fine with marking the ASTMerge tests with XFAIL on windows.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92600/new/

https://reviews.llvm.org/D92600



More information about the cfe-commits mailing list