[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

Thu Dec 10 04:39:50 PST 2020

aaron.ballman added a comment.

In D92600#2443716 <https://reviews.llvm.org/D92600#2443716>, @tmroeder wrote:

> @aaron.ballman It looks like those template tests fail on x64 windows; this is a problem that came up with D58292 <https://reviews.llvm.org/D58292> as well. It ended up getting rolled back because template-based tests failed on windows, and I had to remove the tests and resubmit.
>
> I'm not sure what the right way is to fix these tests: skip them on Windows? If so, then can you please tell me how to do that?

Looking at the changes you made, I'm not certain why one test would work and one test would fail -- however, the usual issue with template tests on Windows is that the default behavior on Windows is to match the MSVC template behavior and so you sometimes need to pass `-fno-delayed-template-parsing` to those tests to get the same behavior as on other platforms.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92600/new/

https://reviews.llvm.org/D92600