[PATCH] D92996: [VE] Remove -faddrsig and -fnoaddrsig tests

[Kazushi Marukawa via Phabricator via cfe-commits]

kaz7 added a comment.

Thank you for additional suggestions.  I'll make next patch like "optimize ve-toolchain.c and .cpp."  Thank you so much!



================
Comment at: clang/test/Driver/ve-toolchain.cpp:72
 
 // RUN: %clangxx -### -target ve %s 2>&1 | FileCheck -check-prefix=DEFINITARRAY %s
 // DEFINITARRAY: clang{{.*}} "-cc1"
----------------
MaskRay wrote:
> Most newer toolchains default to -fuse-init-array. There is probably very little value testing -f[no-]use-init-array
That's make sense.  I'll remove that in next patch.


================
Comment at: clang/test/Driver/ve-toolchain.cpp:112
 
 // RUN: %clangxx -### -target ve --stdlib=c++ %s 2>&1 | \
 // RUN:    FileCheck -check-prefix=LINK %s
----------------
MaskRay wrote:
> Such tests should use `--sysroot` and a fake tree (see `Inputs/basic_*_tree`), otherwise clang may find the toolchain under /usr
Thanks!  I'll try to add that one too in next patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92996/new/

https://reviews.llvm.org/D92996