[PATCH] D92996: [VE] Remove -faddrsig and -fnoaddrsig tests

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 9 22:58:25 PST 2020


MaskRay added inline comments.


================
Comment at: clang/test/Driver/ve-toolchain.cpp:72
 
 // RUN: %clangxx -### -target ve %s 2>&1 | FileCheck -check-prefix=DEFINITARRAY %s
 // DEFINITARRAY: clang{{.*}} "-cc1"
----------------
Most newer toolchains default to -fuse-init-array. There is probably very little value testing -f[no-]use-init-array


================
Comment at: clang/test/Driver/ve-toolchain.cpp:112
 
 // RUN: %clangxx -### -target ve --stdlib=c++ %s 2>&1 | \
 // RUN:    FileCheck -check-prefix=LINK %s
----------------
Such tests should use `--sysroot` and a fake tree (see `Inputs/basic_*_tree`), otherwise clang may find the toolchain under /usr


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92996/new/

https://reviews.llvm.org/D92996



More information about the cfe-commits mailing list