[PATCH] D92883: De-templatify EmitCallArgs argument type checking, NFCI

Saleem Abdulrasool via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 8 14:14:59 PST 2020


compnerd accepted this revision.
compnerd added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/CodeGen/CGCall.cpp:3824
+// that may have type parameters in its signature.
+static bool isObjCMethodWithTypeParams(const ObjCMethodDecl *method) {
+  const DeclContext *dc = method->getDeclContext();
----------------
This doesn't entirely match the style, but it is a shuffle after all.  Id say that `DC`, and using `if (const auto *CD =` due to the `dyn_cast` would be nice, but that isn't important.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92883/new/

https://reviews.llvm.org/D92883



More information about the cfe-commits mailing list