[PATCH] D92883: De-templatify EmitCallArgs argument type checking, NFCI

[Reid Kleckner via Phabricator via cfe-commits]

rnk created this revision.
rnk added reviewers: compnerd, aeubanks, rsmith.
rnk requested review of this revision.
Herald added a project: clang.

This template exists to abstract over FunctionPrototype and
ObjCMethodDecl, which have similar APIs for storing parameter types. In
place of a template, use a PointerUnion with two cases to handle this.
Hopefully this improves readability, since the type of the prototype is
easier to discover. This allows me to sink this code, which is mostly
assertions, out of the header file and into the cpp file. I can also
simplify the overloaded methods for computing isGenericMethod, and get
rid of the second EmitCallArgs overload.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D92883

Files:
  clang/lib/CodeGen/CGCall.cpp
  clang/lib/CodeGen/CGExprCXX.cpp
  clang/lib/CodeGen/CodeGenFunction.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92883.310341.patch
Type: text/x-patch
Size: 8339 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201208/b17816a4/attachment.bin>