[PATCH] D92658: [libTooling] Add `describe` stencil for formatting AST nodes for diagnostics.

Tom Lokovic via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 4 12:07:13 PST 2020


tdl-g added inline comments.


================
Comment at: clang/unittests/Tooling/StencilTest.cpp:513
 
+TEST(StencilToStringTest, DescribeOp) {
+  auto S = describe("Id");
----------------
ymandel wrote:
> tdl-g wrote:
> > Can you add a comment (or a more detailed test name) explaining what this test case is validating?
> It's the same pattern for (nearly) all of the StencilToStringTest cases.  Might a comment on the fixture be a better place?
Oh, sorry, I thought the "repr" was a stencil combinator, I didn't realize it was part of the raw string quotation.  My bad.

LGTM as is.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92658/new/

https://reviews.llvm.org/D92658



More information about the cfe-commits mailing list