[PATCH] D92658: [libTooling] Add `describe` stencil for formatting AST nodes for diagnostics.
Yitzhak Mandelbaum via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Dec 4 11:37:21 PST 2020
ymandel added a comment.
thanks!
================
Comment at: clang/unittests/Tooling/StencilTest.cpp:513
+TEST(StencilToStringTest, DescribeOp) {
+ auto S = describe("Id");
----------------
tdl-g wrote:
> Can you add a comment (or a more detailed test name) explaining what this test case is validating?
It's the same pattern for (nearly) all of the StencilToStringTest cases. Might a comment on the fixture be a better place?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92658/new/
https://reviews.llvm.org/D92658
More information about the cfe-commits
mailing list