[PATCH] D92633: Add -f[no-]direct-access-external-data to deprecate -mpie-copy-relocations

Fri Dec 4 10:59:49 PST 2020

tmsriram added a comment.

In D92633#2434212 <https://reviews.llvm.org/D92633#2434212>, @MaskRay wrote:

> In D92633#2434166 <https://reviews.llvm.org/D92633#2434166>, @tmsriram wrote:
>
>> LGTM.  I checked it completely and the patch makes total sense to me.
>
> Thanks! The name bothers me a bit. There are two parts "direct-access" (direct access relocations like absolute relocations and PC-relative relocations) "external-data" (this is for an external global data symbol with default visibility) (-fno-plt is a similar option for function symbols)
>
> "external global data symbol with default visibility" is apparently too long and not suitable for an option name.
> I do not know how to fit `default` into the name, so I just omit it.
> I think `external` implies `global` (undefined local symbols are not allowed, either by the assembler or by the linker in various binary formats), so `external-global` probably does not convey more information than `external-data`. In the end I still think `-fdirect-access-external-data` is the best name I can think of...

Acknowledged.  To me, global is more specific but I do not want to push this any further. Feel free to keep the current choice :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92633/new/

https://reviews.llvm.org/D92633