[PATCH] D92633: Add -f[no-]direct-access-external-data to deprecate -mpie-copy-relocations

[Sriraman Tallam via Phabricator via cfe-commits]

tmsriram added a comment.

Sorry just one more thing which is a bit concerning:

When I do  :

$ clang -fPIC -frxternal-data-access foo.c

You will omit the GOT but this object can go into a shared object and break the build as this does not apply to shared objects?  Should we allow this at all for -fPIC?  I dont see a need for this but if you want to,  maybe warn?  The user should know that this cannot go into a shared object right?
I am also ok with commenting that this option can do bad things for -fPIC and the user should know what they are doing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92633/new/

https://reviews.llvm.org/D92633