[PATCH] D92439: Fix missing error for use of 128-bit integer inside SPIR64 device code.

Wed Dec 2 08:54:10 PST 2020

jyu2 added inline comments.

================
Comment at: clang/lib/Basic/Targets/SPIR.h:108
+
+  virtual bool hasInt128Type() const { return false; }
 };
----------------
jdoerfert wrote:
> Not virtual but override.
Thank you.  I will change that.

================
Comment at: clang/lib/Sema/Sema.cpp:241
+      (Context.getAuxTargetInfo() &&
+       Context.getAuxTargetInfo()->hasInt128Type())) {
     // If either of the 128-bit integer types are unavailable to name lookup,
----------------
jdoerfert wrote:
> I don't understand why this (and the changes below) are necessary. Host and device compilation are separate. This should not be any different to CUDA, HIP, or OpenMP offload which seem not to require this.
As far as I can know, in real compile, the auxtarget should be also set for example SYCL.  May be that is only for our compiler.  I am not sure what do you mean by it should same with CUDA, HIP...?  Do you mean, CUDA(or HIP...) target should also not support 128-bit integer?  If so, I don't see any error emit for CUDA when I try with nvptx64-nvidia-cuda.

Thanks.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92439/new/

https://reviews.llvm.org/D92439