[PATCH] D92439: Fix missing error for use of 128-bit integer inside SPIR64 device code.

[Johannes Doerfert via Phabricator via cfe-commits]

jdoerfert requested changes to this revision.
jdoerfert added inline comments.
This revision now requires changes to proceed.


================
Comment at: clang/lib/Basic/Targets/SPIR.h:108
+
+  virtual bool hasInt128Type() const { return false; }
 };
----------------
Not virtual but override.


================
Comment at: clang/lib/Sema/Sema.cpp:241
+      (Context.getAuxTargetInfo() &&
+       Context.getAuxTargetInfo()->hasInt128Type())) {
     // If either of the 128-bit integer types are unavailable to name lookup,
----------------
I don't understand why this (and the changes below) are necessary. Host and device compilation are separate. This should not be any different to CUDA, HIP, or OpenMP offload which seem not to require this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92439/new/

https://reviews.llvm.org/D92439