[PATCH] D90484: FileManager: Add FileEntryRef::getDir, returning DirectoryEntryRef

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 30 14:09:34 PST 2020


dexonsmith added inline comments.


================
Comment at: clang/unittests/Basic/FileEntryTest.cpp:95
 
   OptionalFileEntryRefDegradesToFileEntryPtr M0;
   OptionalFileEntryRefDegradesToFileEntryPtr M1 = R1;
----------------
jansvoboda11 wrote:
> Dead variable, do we need it?
Thanks, nice catch, that looks vestigial. I'll delete that line in a follow-up.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90484/new/

https://reviews.llvm.org/D90484



More information about the cfe-commits mailing list