[PATCH] D90484: FileManager: Add FileEntryRef::getDir, returning DirectoryEntryRef

Jan Svoboda via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 30 08:58:56 PST 2020


jansvoboda11 accepted this revision.
jansvoboda11 added a comment.
This revision is now accepted and ready to land.

Left tiny question inline, but LGTM anyways.



================
Comment at: clang/unittests/Basic/FileEntryTest.cpp:95
 
   OptionalFileEntryRefDegradesToFileEntryPtr M0;
   OptionalFileEntryRefDegradesToFileEntryPtr M1 = R1;
----------------
Dead variable, do we need it?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90484/new/

https://reviews.llvm.org/D90484



More information about the cfe-commits mailing list