[PATCH] D91915: [clang-tidy] Fix RenamerClangTidy checks trying to emit a fix that isnt a valid identifier

[Nathan James via Phabricator via cfe-commits]

njames93 added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:525
+    return "; cannot be fixed because '" + Fixup +
+           "' is not a valid identifier";
 
----------------
gribozavr2 wrote:
> I don't think we need to tell that to the user. When Clang can't provide a fix, it just silently omits it. It does not help the user to know. that Clang tried, but failed.
> 
> (This message could be also read as "this code is so bad it can't be fixed"...)
So just return an empty string.
The user will see the normal diagnostic message but there will be no fix-its available.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91915/new/

https://reviews.llvm.org/D91915