[PATCH] D91915: [clang-tidy] Fix RenamerClangTidy checks trying to emit a fix that isnt a valid identifier
Dmitri Gribenko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Nov 22 07:52:30 PST 2020
gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:525
+ return "; cannot be fixed because '" + Fixup +
+ "' is not a valid identifier";
----------------
I don't think we need to tell that to the user. When Clang can't provide a fix, it just silently omits it. It does not help the user to know. that Clang tried, but failed.
(This message could be also read as "this code is so bad it can't be fixed"...)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91915/new/
https://reviews.llvm.org/D91915
More information about the cfe-commits
mailing list