[PATCH] D90174: [HIP] Fix regressions due to fp contract change
Artem Belevich via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 11 10:24:23 PST 2020
tra added a comment.
In D90174#2387518 <https://reviews.llvm.org/D90174#2387518>, @scanon wrote:
> Strictly speaking, fp-contract=fast probably should have been a separate flag entirely (since there's no _expression_ being contracted in fast). Unfortunately, that ship has sailed, and it does constrain our ability to choose an accurate name somewhat.
>
> What if we just spell it out? fast-respect-pragma? fast-when-unspecified? I don't think that we really need to try to be as brief as possible with this one.
This sounds reasonable. We already have `-fhonor-nans` and `-fhonor-infinities`. Should we make it `fast-honor-pragma` for consistency?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90174/new/
https://reviews.llvm.org/D90174
More information about the cfe-commits
mailing list