[PATCH] D90849: [dllexport] Avoid multiple codegen assert for explicitly defaulted methods in explicit instantiation definitions (PR47683)
Hans Wennborg via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Nov 9 04:36:38 PST 2020
hans added inline comments.
================
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:5917
// There is no later point when we will see the definition of this
// function, so pass it to the consumer now.
S.Consumer.HandleTopLevelDecl(DeclGroupRef(MD));
----------------
thakis wrote:
> should this grow a `assert(TSK != TSK_ExplicitInstantiationDefinition)` for symmetry?
Hmm no, we can still have TSK==TSK_ExplicitInstantiationDefinition here, it's just for explicitly defaulted methods where we don't want to pass it to the consumer.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90849/new/
https://reviews.llvm.org/D90849
More information about the cfe-commits
mailing list