[PATCH] D90849: [dllexport] Avoid multiple codegen assert for explicitly defaulted methods in explicit instantiation definitions (PR47683)

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 9 04:11:07 PST 2020


thakis accepted this revision.
thakis added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:5917
         // There is no later point when we will see the definition of this
         // function, so pass it to the consumer now.
         S.Consumer.HandleTopLevelDecl(DeclGroupRef(MD));
----------------
should this grow a `assert(TSK != TSK_ExplicitInstantiationDefinition)` for symmetry?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90849/new/

https://reviews.llvm.org/D90849



More information about the cfe-commits mailing list