[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

Chi Chun Chen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 6 20:25:33 PST 2020


cchen added inline comments.


================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8572
       if (PartialStruct.Base.isValid())
+        CurInfo.NonContigInfo.Dims.push_back(0);
         emitCombinedEntry(CombinedInfo, CurInfo.Types, PartialStruct);
----------------
MaskRay wrote:
> Did you forget a pair of braces?
> 
> Please verify whether f2e479db92452594dfe6aff45ab7841f0a8c69a5 is correct.
Yes, I forgot a pair of braces while rebase and can confirm that f2e479db92452594dfe6aff45ab7841f0a8c69a5 is correct. Thanks for your help!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84192/new/

https://reviews.llvm.org/D84192



More information about the cfe-commits mailing list