[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 6 20:11:25 PST 2020


MaskRay added a comment.

> map item can be non-contiguous for target update

The subject appears to describe a situation, but patch subjects should usually be imperative



================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8572
       if (PartialStruct.Base.isValid())
+        CurInfo.NonContigInfo.Dims.push_back(0);
         emitCombinedEntry(CombinedInfo, CurInfo.Types, PartialStruct);
----------------
Did you forget a pair of braces?

Please verify whether f2e479db92452594dfe6aff45ab7841f0a8c69a5 is correct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84192/new/

https://reviews.llvm.org/D84192



More information about the cfe-commits mailing list