[PATCH] D89899: [CodeGen] Implement [[likely]] and [[unlikely]] for the iteration statements

[Mark de Wever via Phabricator via cfe-commits]

Mordante marked an inline comment as done.
Mordante added a comment.

Thanks for the review.



================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3161
+   InGroup<IgnoredAttributes>;
+def note_attribute_has_no_effect_here : Note<
+  "annotating the %select{infinite loop}0 here">;
----------------
aaron.ballman wrote:
> As @rjmccall pointed out in the other review, this isn't really a generic note. I'd mildly recommend renaming the note and removing the select.
I'll do that and the same for the warn.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89899/new/

https://reviews.llvm.org/D89899