[PATCH] D89899: [CodeGen] Implement [[likely]] and [[unlikely]] for the iteration statements

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM aside from a request about the note. Thank you for this!



================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3161
+   InGroup<IgnoredAttributes>;
+def note_attribute_has_no_effect_here : Note<
+  "annotating the %select{infinite loop}0 here">;
----------------
As @rjmccall pointed out in the other review, this isn't really a generic note. I'd mildly recommend renaming the note and removing the select.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89899/new/

https://reviews.llvm.org/D89899