[PATCH] D84604: Thread safety analysis: Consider global variables in scope

Aaron Puchert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 29 16:42:22 PDT 2020


aaronpuchert added a comment.

Pushed a fix in rGbbed8cfe80cd27d3a47d877c7608d9be4e487d97 <https://reviews.llvm.org/rGbbed8cfe80cd27d3a47d877c7608d9be4e487d97>. For now we just consider all static members as inaccessible, so we'll treat them as we did before this change.

I have proposed making the check stronger for non-static members in D87194 <https://reviews.llvm.org/D87194>, perhaps it makes sense to extend this to static members as well so that it fires on `DoStuff()` again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84604/new/

https://reviews.llvm.org/D84604



More information about the cfe-commits mailing list