[PATCH] D84604: Thread safety analysis: Consider global variables in scope

[Aaron Puchert via Phabricator via cfe-commits]

aaronpuchert added a comment.

In D84604#2363134 <https://reviews.llvm.org/D84604#2363134>, @rupprecht wrote:

> I'm seeing failures which I think are due to this patch -- I don't have a nice godbolt repro yet, but it's something like:

Yes, that's very likely.

> I'm also seeing the same error for `DoThings()`, which doesn't make sense. When I add it, I then get errors that `mu_` is private, and therefore needs to be made public or friended for the thread analysis -- which is not at all a good change (the mutex should be encapsulated in the class). Even though it's "global" in the linkage sense, it's not visible outside of the class.

I'll see if I can fix this quickly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84604/new/

https://reviews.llvm.org/D84604