[PATCH] D90366: [ThinLTO] Strenghten the test for .llvmcmd embedding

Thu Oct 29 08:03:04 PDT 2020

mtrofin added a comment.

In D90366#2362052 <https://reviews.llvm.org/D90366#2362052>, @tejohnson wrote:

> The motivation and effects of the change are unclear to me. Does this mean that the .llvmcmd section is always emitted? Or always emitted whenever any bitcode embedding is requested?

This just means the arguments are captured in memory. Nothing else changes. The only penalty is that a char vector (the captured args) are carried around even if .llvmcmd wasn't generated.

We could maybe add a test that no explicit optin to emitting .llvmcmd => no section (briefly looked, doesn't seem to exist for either non- or thinlto)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90366/new/

https://reviews.llvm.org/D90366