[PATCH] D90366: [ThinLTO] Strenghten the test for .llvmcmd embedding

Teresa Johnson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 29 07:56:41 PDT 2020


tejohnson added a comment.

The motivation and effects of the change are unclear to me. Does this mean that the .llvmcmd section is always emitted? Or always emitted whenever any bitcode embedding is requested?



================
Comment at: clang/test/CodeGen/thinlto_embed_bitcode.ll:28
 ; RUN: %clang -target x86_64-unknown-linux-gnu -O2 -o %t-redo.o -x ir %t-embedded.bc -c -fthinlto-index=%t.o.thinlto.bc -mllvm -lto-embed-bitcode=post-merge-pre-opt -mllvm -thinlto-assume-merged
+; The resulting .o is almost the 
+; RUN: llvm-strip --strip-all %t-redo.o 
----------------
Incomplete sentence


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90366/new/

https://reviews.llvm.org/D90366



More information about the cfe-commits mailing list