[PATCH] D39086: Performance tracing facility for clangd.

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 28 10:26:10 PDT 2020


kadircet added inline comments.


================
Comment at: clang-tools-extra/trunk/unittests/clangd/TraceTests.cpp:57
+    }
+    std::string VS = V->getValue(Tmp).str();
+    if (VS != I->second) {
----------------
RKSimon wrote:
> @sammccall PVS Studio is reporting a potential null dereference here: https://www.viva64.com/en/b/0771/ (Snippet 8)
Sent out https://github.com/llvm/llvm-project/commit/68b48339e5b2e7c5f9b74e790b4a4e2419a0a50b


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D39086/new/

https://reviews.llvm.org/D39086



More information about the cfe-commits mailing list