[PATCH] D39086: Performance tracing facility for clangd.

[Simon Pilgrim via Phabricator via cfe-commits]

RKSimon added inline comments.
Herald added subscribers: usaxena95, kadircet, arphaman, MaskRay.


================
Comment at: clang-tools-extra/trunk/unittests/clangd/TraceTests.cpp:57
+    }
+    std::string VS = V->getValue(Tmp).str();
+    if (VS != I->second) {
----------------
@sammccall PVS Studio is reporting a potential null dereference here: https://www.viva64.com/en/b/0771/ (Snippet 8)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D39086/new/

https://reviews.llvm.org/D39086