[PATCH] D90129: Better source location for -Wignored-qualifiers on trailing return types

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 28 08:11:41 PDT 2020


aaron.ballman added inline comments.


================
Comment at: clang/include/clang/Sema/DeclSpec.h:1509
+    SourceLocation getTrailingReturnTypeLoc() const {
+      return SourceLocation::getFromRawEncoding(TrailingReturnTypeLoc);
+    }
----------------
aaronpuchert wrote:
> aaron.ballman wrote:
> > Should we `assert(HasTrailingReturnType);`?
> Makes sense to me. Ok if I add the assertion to this and the previous function for consistency?
Fine by me!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90129/new/

https://reviews.llvm.org/D90129



More information about the cfe-commits mailing list